Skip to content

tikv config: 补充 resource-metering.enable-network-io-collection 配置项说明#21424

Closed
yibin87 wants to merge 5 commits intopingcap:masterfrom
yibin87:tikv_cfg_update
Closed

tikv config: 补充 resource-metering.enable-network-io-collection 配置项说明#21424
yibin87 wants to merge 5 commits intopingcap:masterfrom
yibin87:tikv_cfg_update

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Mar 11, 2026 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

补充 tikv-configuration-file.md 中 resource-metering.enable-network-io-collection 配置项说明，包含以下内容：

  • 默认值为 false
  • 开启后会采集网络流量和逻辑 I/O
  • 说明该配置对 Resource Metering 上报时 Top N 筛选和按 Region 维度上报的影响
  • 补充逻辑 I/O 与实际物理 I/O 的区别说明，避免混淆
  • 同时移除该文件中两个容易触发 link checker 429 的 GitHub 外链，避免 CI 因限流失败

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2026
yibin87
yibin87 commented Mar 11, 2026
View reviewed changes
@yibin87 yibin87 requested review from hfxsd and nolouch March 11, 2026 09:20
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Mar 11, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2026

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2026

@zhaoshangzi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Mar 12, 2026
qiancai
qiancai reviewed Mar 16, 2026
View reviewed changes
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yibin87
Copy link
Contributor Author

yibin87 commented Mar 17, 2026

Merged into #21431.

@yibin87 yibin87 closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai left review comments

@nolouch nolouch nolouch approved these changes

@hfxsd hfxsd Awaiting requested review from hfxsd

+1 more reviewer

@zhaoshangzi zhaoshangzi zhaoshangzi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qiancai qiancai

Labels

needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yibin87 @nolouch @qiancai @zhaoshangzi @hfxsd